Improvement on testing would be great and its awesome that there’s people that want to contribute in that way.
Its awesome that people want to improve test coverage.
I’d like to mention that if you want to improve test coverage, maybe check with @SPF13 to see what you shouldn’t work on test wise as he is working some changes that sounds like it might affect a number of things.
When working on tests please break it up into bits, don’t try to fix a bunch of stuff at once and contribute a large pull request that affects a bunch of stuff.
Instead, submit smaller pull requests that address a logical unit, whether its tests for a struct, changes to code to fix things exposed by new tests, etc.
Also, for those who are contributing code please make sure you either update tests or add tests for your changes, unless the changes are such that testing isn’t required. When adding tests for bug fixes its helpful to identify, in the comments, what issue led to this test/fix. This helps prevent regression in the future and is being nice to other developers that might have to look into the code.
I too need to make sure that the changes I submit have proper test coverage-where appropriate.
@OwenWaller, @tatsushid, @tommasop, it might be good to move the testing discussion to Owen’s original thread, listed above, or a new one ,to help co-ordinate/discuss improving tests.
edit: oops, I guess I elided the comment referring to @OwenWaller’s testing thread: