Comment shortcode deprecated?

support
1

Hi there,

After updating to v0.145.0 just now I’m getting this warning:

WARN The "comment" shortcode was deprecated in v0.143.0 and will be removed in a future release. Please use HTML comments instead

This is not an option. HTML comments make their way into the published html while comments gated with the comment shortcode don’t.

So the two types of comments do different things, and that’s why they should both be enabled-

Or is it that I overlook another way of writing comments that don’t find their way into the public?

@jmooring didn’t mention one here, he just dismissed the whole topic.

Please advise how I can really comment out my private notes for the next revision. Or even better: Un-deprecate this important feature.

Thanks in advance
harald

2

Which content format are you using?

3

I’m using Markdown (Goldmark)

4

I cannot reproduce what you describe. Try it:

git clone --single-branch -b hugo-forum-topic-54326 https://github.com/jmooring/hugo-testing hugo-forum-topic-54326
cd hugo-forum-topic-54326
hugo && cat public/index.html

If you add this to your site configuration…

[markup.goldmark.renderer]
unsafe = true

… the comments will be published, but are removed in production when you minify (e.g., hugo --minify).

5

Thanks, Joe, this did the job.

For several reasons I had unsafe = truebut I didn’t minify.

So I’ll probably look for a configuration option to *always" minify. Maybe create an alias.

After all: HTML comments are somewhat easier to type than the shortcode.

That settled the topic can be closed.

Thanks again
harald

6

No, I did not.

The user (@tyco) asked a very good question, and I provided a detailed explanation.

Your characterization is… unfortunate.

1 Like
7

Right, you did everything necessary to deal with tyco’s question.

My choice of words was unfortunate.

Sorry.

1 Like
8

This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.