I wanted to ask here before I take it to the Netlify forums. I have a free account and don’t expect any speedy resolve there
I have a website, that right now fails to be built by Hugo. A config variable is not defined and not checked with isset. So Hugo fails and produces 0 pages.
Netlify still deploys the site.
https://app.netlify.com/teams/hugonewsletter/builds/6089529a5d59aa00080ca97c
(that link should be visible public, if not, let me know and I’ll copy paste the log)
I would expect Hugo to fail with an error code and Netlify to stop the build unsuccessful. Is that wrong, a known issue or is there a way to let Netlify know that the build failed somehow?
PS: the log seems to be non-public… here it is:
Summary
7:18:34 PM: Waiting for other deploys from your team to completenpm fund for details@netlify /build 11.3.1github.com/dnb-hugo/blocks v0.0.0-20210428112424-aa4401c3c09fgithub.com/dnb-hugo/components v0.0.0-20210420145220-7bd6f709ca22github.com/dnb-hugo/libraries v1.0.7hugonewsletter.com @3.0.99 buildhugonewsletter.com @3.0.99 build:hugo
That really looks like it should be failing on Netlify as well… Weird.
No answers to give you, just an agreement that something looks not right. Also would like to know and follow along with what happens here.
There was no change in the output folder, so nothing for Netlify to deploy, so no change to your site. The previously built version will remain until your Hugo build completes and there are changes for Netlify to deploy.
Netlify still deploys the site.
No, it doesn’t look like it did. Netlify didn’t replace your existing site with a broken one, which is good.
zwbetz
April 28, 2021, 2:05pm
5
@davidsneighbour is your local hugo version the same as your netlify hugo version?
Edit: Also, what are the contents of this build script?
$ ./bin/netlify.sh
@zwbetz : Edit: Also, what are the contents of this build script?
https://github.com/dnb-hugo/hugonewsletter.com/blob/main/bin/netlify.sh
just a sequence of “get the latest changes from upstream” and “run hugo”
and hugo run build is running these commands:
"build": "npm run build:hugo",
"build:hugo": "hugo --gc --minify",
@nternetinspired
I am pretty sure I don’t understand that. Public is not part of the repository so there is no public at that point and Hugo does not create a public folder. Netlify deploys an empty page (dark green with page not found error) instead of the last deploy that had pages in public. Hugo does not finish it’s job because there are errors. Netlify then deploys “nothing” as if Hugo was successful.
Your netlify.sh should check the exit status of the hugo command and exit appropriately. Something like this:
hugo mod get -u ./...
if [[ $? -ne 0 ]] ; then
echo "hugo build failed"
exit 1
fi
I would suggest doing something similar for every command executed by netlify.sh.
1 Like
That did the trick. And I remembered having read something about the exit code of Hugo recently having changed… anyway, it works
system
May 1, 2021, 2:22pm
10
This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.
