Add JSON to --minify

ttntm · October 16, 2018, 4:06pm

Hi all,

I recently added some ld+json type strucutred data to a site that gets built running hugo --minify.

After the build process, I noticed that --minify seems to ignore the JSON, leaving it as it came from the partial its defined in.

It would be great, if hugo --minify would also support the minification of JSON, as running JSON filled with things like {{ .Site.Params.author }} through any online minifiers doesn’t seem feasible because they interpret that as syntax errors.

Sorry if I missed something here, but I didn’t find anything on that subject using the search here.

kaushalmodi · October 16, 2018, 4:14pm

Looks like “ld+json” mimetypes should already be minified if the “application” type is set to those correctly.

There’s a test in Hugo that verifies that “ld+json” minification works:

github.com

gohugoio/hugo/blob/3dafe206e31bb92f27802a04bf9159cbc20af234/minifiers/minifiers_test.go#L62


		{media.Type{MainType: "application", SubType: "javascript"}, rawJS, minJS},
		{media.Type{MainType: "application", SubType: "x-javascript"}, rawJS, minJS},
		{media.Type{MainType: "application", SubType: "x-ecmascript"}, rawJS, minJS},
		{media.Type{MainType: "text", SubType: "ecmascript"}, rawJS, minJS},
		{media.Type{MainType: "text", SubType: "javascript"}, rawJS, minJS},
		{media.Type{MainType: "text", SubType: "x-javascript"}, rawJS, minJS},
		{media.Type{MainType: "text", SubType: "x-ecmascript"}, rawJS, minJS},
		// JSON Regex minifiers
		{media.Type{MainType: "application", SubType: "json"}, rawJSON, minJSON},
		{media.Type{MainType: "application", SubType: "x-json"}, rawJSON, minJSON},
		{media.Type{MainType: "application", SubType: "ld+json"}, rawJSON, minJSON},
		{media.Type{MainType: "text", SubType: "json"}, rawJSON, minJSON},
		{media.Type{MainType: "text", SubType: "x-json"}, rawJSON, minJSON},
		{media.Type{MainType: "text", SubType: "ld+json"}, rawJSON, minJSON},
	} {
		var b bytes.Buffer


		assert.NoError(m.Minify(test.tp, &b, strings.NewReader(test.rawString)))
		assert.Equal(test.expectedMinString, b.String())
	}

ttntm · October 16, 2018, 5:11pm

It must have been late yesterday, just found the reason:

I was using Hugo 0.49.2 locally, while the netlify.toml file was still requesting 0.47.

Changing that just some minutes ago, Netlify built a site with minified ld+json data - just as expected.

Sorry for that, this topic should probably be closed and moved to support now…

Topic		Replies	Views
--minify breaks on JSON since 59.0 support	2	492	November 1, 2019
0.70 Extended JSON parse error on --minify: How to debug? support	17	2010	May 18, 2020
--minify for custom outputs support	1	457	August 17, 2018
Minify the output of a partial support	13	2639	September 28, 2018
Hugo 0.50 fails when --minify is enabled on content that worked fine in hugo 0.48 support	9	888	November 7, 2018

Add JSON to --minify

Related topics